Lehel44 commented on a change in pull request #5111:
URL: https://github.com/apache/nifi/pull/5111#discussion_r644082430
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/FlowController.java
##########
@@ -311,7 +311,7 @@
private final StandardFlowManager flowManager;
private final RepositoryContextFactory repositoryContextFactory;
private final RingBufferGarbageCollectionLog gcLog;
- private final FlowEngine longRunningTaskMonitorThreadPool;
+ private final Optional<FlowEngine> longRunningTaskMonitorThreadPool;
Review comment:
In case of invalid time durations this is what I see from logs:
`2021-06-02 17:30:59,113 WARN [main] o.apache.nifi.controller.FlowController
Could not retrieve value for nifi.monitor.long.running.task.schedule.
2021-06-02 17:30:59,114 WARN [main] o.apache.nifi.controller.FlowController
Could not initialize LongRunningTaskMonitor.
java.lang.IllegalArgumentException: Value 'saf' is not a valid time duration`
I think as an enhancement we could provide the allowed time durations here
too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
