exceptionfactory commented on a change in pull request #5110: URL: https://github.com/apache/nifi/pull/5110#discussion_r644445054
########## File path: nifi-commons/nifi-security-kms/src/main/java/org/apache/nifi/security/kms/KeyProviderFactory.java ########## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.security.kms; + +import org.apache.commons.codec.DecoderException; +import org.apache.nifi.security.kms.configuration.FileBasedKeyProviderConfiguration; +import org.apache.nifi.security.kms.configuration.KeyProviderConfiguration; +import org.apache.nifi.security.kms.configuration.KeyStoreKeyProviderConfiguration; +import org.apache.nifi.security.kms.configuration.StaticKeyProviderConfiguration; +import org.apache.commons.codec.binary.Hex; +import org.apache.nifi.security.kms.reader.KeyReaderException; + +import javax.crypto.SecretKey; +import javax.crypto.spec.SecretKeySpec; +import java.nio.file.Path; +import java.nio.file.Paths; +import java.security.KeyStore; +import java.util.HashMap; +import java.util.Map; + +/** + * Key Provider Factory + */ +public class KeyProviderFactory { + private static final String SECRET_KEY_ALGORITHM = "AES"; + + /** + * Get Key Provider based on Configuration + * + * @param configuration Key Provider Configuration + * @return Key Provider + */ + public static KeyProvider getKeyProvider(final KeyProviderConfiguration<?> configuration) { Review comment: Thanks for the suggestion, that is an interesting idea. The purpose of the `KeyProviderFactory` is to abstract the details of instantiating a `KeyProvider`, so going in the direction of `KeyProviderCreator` seems to create another level of abstraction. The basic purpose of the `KeyProviderConfiguration` classes is to describe the properties necessary to create the associated `KeyProvider`. A different approach could be to have one `KeyProviderConfiguration` with all possible properties, but it would still require branching to determine the required properties. There are probably other options for streamlining and abstracting `KeyProvider` creation, but the current implementation is a variation on the previous approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
