[ 
https://issues.apache.org/jira/browse/NIFI-2900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15575373#comment-15575373
 ] 

ASF GitHub Bot commented on NIFI-2900:
--------------------------------------

Github user mcgilman commented on the issue:

    https://github.com/apache/nifi/pull/1136
  
    Our use of swagger is simply for generating the documentation. The 
swagger.json is generated into the target directory and is not made available 
as part of the released source or convenience binaries.
    
    I think the issue here is the inability of Swagger to understand the use of 
JAXB adapters. These values are String's already as the adapters support 
(un)marshalling them. I would guess that Swagger is simply reading the type of 
the property as a `java.util.Date` and marking it a date-time.
    
    I would suggest we update the `ApiModelProperty` annotation of all fields 
that use any JAXB adapters to accurately reflect the actual data type a client 
can expect. It looks like there is a dataType field in the annotation. I'm not 
certain but I would expect this to override the data type in the method 
signature.
     


> DateTime API Endpoints don't respect RFC 3339
> ---------------------------------------------
>
>                 Key: NIFI-2900
>                 URL: https://issues.apache.org/jira/browse/NIFI-2900
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core Framework
>    Affects Versions: 1.0.0
>            Reporter: Stephane Maarek
>
> Hi,
> the endpoint /flow/process-group/id is supposed to return lastRefreshed as 
> part of ProcessGroupFlowDTO as a DateTime, as indicated here:
> lastRefreshed string (date-time)      optional        The time the flow for 
> the process group was last refreshed.
> as it currently stands, what I am getting doesn't look like a timestamp:
> "lastRefreshed":"14:02:46 AEDT"
> I'm not sure how much of the overall API is affected
> Edit:
> Actually, it seems every date a "date-time" is created we expect the format 
> "HH:mm:ss z".
> As per the OpenAPI specs, if a field is annotated "date-time", it should 
> respect the RFC 3339 convention 
> (https://github.com/OAI/OpenAPI-Specification/blob/master/versions/2.0.md#data-types).
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to