lordgamez commented on a change in pull request #1073:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1073#discussion_r647430794
##########
File path: libminifi/include/utils/StringUtils.h
##########
@@ -137,6 +137,7 @@ class StringUtils {
static std::vector<std::string> split(const std::string &str, const
std::string &delimiter);
static std::vector<std::string> splitAndTrim(const std::string &str, const
std::string &delimiter);
+ static std::vector<std::string> splitAndTrimOnString(std::string str, const
std::string& delimiter);
Review comment:
Thanks for both of your inputs. I changed `split` and `splitAndTrim` to
use full strings and changed the semantics to keep the zero length segments. I
also added `*RemovingEmpty` versions for utility. Changes are incorporated in
3ee4f1357bf03ec5bed69a3ca63801d128e739f8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
