Lehel44 commented on a change in pull request #5088:
URL: https://github.com/apache/nifi/pull/5088#discussion_r668297279
##########
File path:
nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/main/java/org/apache/nifi/snmp/operations/SNMPRequestHandlerFactory.java
##########
@@ -26,9 +26,9 @@
public static SNMPRequestHandler createStandardRequestHandler(final
SNMPConfiguration configuration) {
final SNMPFactory snmpFactory = new CompositeSNMPFactory();
- final Snmp snmpClient =
snmpFactory.createSnmpManagerInstance(configuration);
+ final Snmp snmpManager =
snmpFactory.createSnmpManagerInstance(configuration);
Review comment:
I think this has enough complexity to deserve a separate creator class.
It is also extensively used in tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
