lordgamez commented on a change in pull request #1126:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1126#discussion_r671124065
##########
File path: extensions/script/python/ExecutePythonProcessor.cpp
##########
@@ -53,79 +53,39 @@ core::Relationship
ExecutePythonProcessor::Success("success", "Script successes"
core::Relationship ExecutePythonProcessor::Failure("failure", "Script
failures");
void ExecutePythonProcessor::initialize() {
- // initialization requires that we do a little leg work prior to onSchedule
- // so that we can provide manifest our processor identity
Review comment:
I checked the manifest before and after this change, but I could not see
any additional data transferred. I think with this processor there is no need
for any additional data, as the executed processor is stored in the attribute
of the `Script File` or the `Script Body` attribute and only the same manifest
data is required as for any other processor.
However my guess is that additional manifest data is needed if we are using
native python processors where the identity of those processors should be
included in the manifest. I'm not sure if this refers to the python processors,
how they are connected to the `ExecutePythonProcessor`, I still have to
investigate and test the inner workings of those.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
