exceptionfactory opened a new pull request #5223:
URL: https://github.com/apache/nifi/pull/5223
#### Description of PR
NIFI-7443 Corrects the behavior of SFTP processors when the `Send Keep Alive
On Timeout` property is enabled.
Although enabling `Send Keep Alive` configures a `KeepAliveProvider` for
SSHJ, the internal default value for Keep Alive Interval is 0, which means that
SSHJ never starts the Keep Alive Thread.
Setting a value of 5 seconds for the Keep Alive Interval works together with
the default Max Alive Count value of 5, resulting in a timeout of 25 seconds
before the Keep Alive Runner considers the connection lost.
This behavior can be verified at runtime by setting the `net.schmizz.sshj`
logger to `DEBUG` and configuring the `FetchSFTP` processor with `Send Keep
Alive On Timeout` set to `true`. SSHJ logs the following message when the Keep
Alive Thread is running:
```
DEBUG [keep-alive] n.schmizz.sshj.connection.ConnectionImpl Making global
request for `keepal...@openssh.com`
```
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [X] Has your PR been rebased against the latest commit within the target
branch (typically `main`)?
- [X] Is your initial contribution a single, squashed commit? _Additional
commits in response to PR reviewer feedback should be made on this branch and
pushed to allow change tracking. Do not `squash` or use `--force` when pushing
to allow for clean monitoring of changes._
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via `mvn
-Pcontrib-check clean install` at the root `nifi` folder?
- [X] Have you written or updated unit tests to verify your changes?
- [X] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main
`LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main
`NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for
build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
