martinzink commented on a change in pull request #1138: URL: https://github.com/apache/nifi-minifi-cpp/pull/1138#discussion_r681693116
########## File path: libminifi/test/unit/MemoryUsageTest.cpp ########## @@ -16,6 +16,9 @@ * limitations under the License. */ +// including the extensions messes up the memory usage +#define EXTENSION_LIST "" Review comment: Yeah I think disabling the extensions like this is fine, however I agree with adding a more clear comment stating that loading extensions increases the baseline memory usage. Or we could query the memory usage before the vector is created and after it. So we test the change in memory usage and not the absolute memory usage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org