exceptionfactory commented on a change in pull request #5262:
URL: https://github.com/apache/nifi/pull/5262#discussion_r683928100
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/src/main/java/org/apache/nifi/web/security/jwt/revocation/JwtRevocationService.java
##########
@@ -14,36 +14,32 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-package org.apache.nifi.admin.service;
+package org.apache.nifi.web.security.jwt.revocation;
-import org.apache.nifi.key.Key;
+import java.time.Instant;
/**
- * Manages NiFi user keys.
+ * JSON Web Token Revocation Service
*/
-public interface KeyService {
-
+public interface JwtRevocationService {
/**
- * Gets a key for the specified user identity. Returns null if the user
has not had a key issued
- *
- * @param id The key id
- * @return The key or null
+ * Delete Expired Revocations
*/
- Key getKey(int id);
+ void deleteExpired();
/**
- * Gets a key for the specified user identity. If a key does not exist,
one will be created.
+ * Is JSON Web Token Identifier Revoked
*
- * @param identity The user identity
- * @return The key
- * @throws AdministrationException if it failed to get/create the key
+ * @param id JSON Web Token Identifier
+ * @return Revoked Status
*/
- Key getOrCreateKey(String identity);
+ boolean isRevoked(String id);
/**
- * Deletes keys for the specified identity.
+ * Set Revoked Status using JSON Web Token Identifier
*
- * @param keyId The user's key ID
+ * @param id JSON Web Token Identifier
+ * @param expiration Expiration of Revocation Status
Review comment:
Thanks for the suggestion, I have updated the documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
