markap14 commented on pull request #5072: URL: https://github.com/apache/nifi/pull/5072#issuecomment-894498931
It doesn't look like the Fingerprint Factory was updated. Will need to make sure it accounts for this. The only thing in the code that I really don't love is the addition of the `void resolveParameterContextReferences()` method to FlowManager. I can understand why it's done this way. But it means that if we call `createParameterContext()` it means that under certain conditions we must also ensure that we call this other resolve method. But only after we're finished creating these param contexts. This just feel brittle to me. Is there some way to update the API here so that we can maybe just insert a batch or otherwise determine the proper ordering, so that we don't have this requirement? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
