gresockj commented on pull request #5072: URL: https://github.com/apache/nifi/pull/5072#issuecomment-894646358
> When testing, I found a couple of interesting things. > > When looking at the Parameter Context, it shows all parameters, inherited and owned by the context you're looking at. They are interspersed. I wonder if it makes more sense to add all of the Parameters owned by the context you're looking at first (i.e., at the top in the UI) because you're most likely to want to see those first, since they are the ones you're updating? Not sure if this makes sense or not. Figured I'd mention it and get your thoughts on it. I like that idea -- I'll try it out and see how it feels. > > Also, there is code, it looks like, that allows for proper ordering of the parameter contexts so that they can be overridden. But once I ran the CLI command to set the inheritance, I couldn't create another Parameter to override. I.e., I created two Parameter Contexts: "Kafka" and "S3". I think created a "Kafka to S3" parameter context and made it inherit from both. The Kafka param context has a parameter named Brokers. I then tried to create a parameter named Brokers in the "Kafka to S3" context, in order to override the one in the "Kafka" context. I think this is intended to work. But when I tried to add it, I got back an error saying that a Parameter already exists with the name Brokers. I don't think this was intended, since it exists only in the inherited context. I think we should still allow it. Good find, this is the UI preventing the parameter from being added -- I'll add a check to allow parameters to be added if the existing one is inherited. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
