szaszm commented on a change in pull request #1138: URL: https://github.com/apache/nifi-minifi-cpp/pull/1138#discussion_r694090751
########## File path: libminifi/src/core/extension/ExtensionManager.cpp ########## @@ -0,0 +1,134 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#include "core/extension/ExtensionManager.h" +#include "core/logging/LoggerConfiguration.h" +#include "utils/file/FileUtils.h" +#include "core/extension/Executable.h" +#include "utils/file/FileMatcher.h" +#include "core/extension/DynamicLibrary.h" + +namespace org { +namespace apache { +namespace nifi { +namespace minifi { +namespace core { +namespace extension { + +namespace { +struct LibraryDescriptor { + std::string name; + std::string dir; + std::string filename; + + bool verify(const std::shared_ptr<logging::Logger>& /*logger*/) const { + // TODO(adebreceni): check signature + return true; + } + + std::string getFullPath() const { + return utils::file::PathUtils::concat_path(dir, filename); + } +}; +} // namespace + +static std::optional<LibraryDescriptor> asDynamicLibrary(const std::string& dir, const std::string& filename) { +#if defined(WIN32) + const std::string extension = ".dll"; +#elif defined(__APPLE__) + const std::string extension = ".dylib"; +#else + const std::string extension = ".so"; +#endif + +#ifdef WIN32 + const std::string prefix = ""; +#else + const std::string prefix = "lib"; +#endif + if (!utils::StringUtils::startsWith(filename, prefix) || !utils::StringUtils::endsWith(filename, extension)) { + return {}; + } + return LibraryDescriptor{ + filename.substr(prefix.length(), filename.length() - extension.length() - prefix.length()), + dir, + filename + }; +} + +std::shared_ptr<logging::Logger> ExtensionManager::logger_ = logging::LoggerFactory<ExtensionManager>::getLogger(); + +ExtensionManager::ExtensionManager() { + modules_.push_back(std::make_unique<Executable>()); + active_module_ = modules_[0].get(); +} + +ExtensionManager& ExtensionManager::get() { + static ExtensionManager instance; + return instance; +} + +bool ExtensionManager::initialize(const std::shared_ptr<Configure>& config) { + static bool initialized = ([&] { + logger_->log_trace("Initializing extensions"); + // initialize executable + active_module_->initialize(config); + std::optional<std::string> pattern = config ? config->get(nifi_extension_path) : std::nullopt; + if (!pattern) return; + std::vector<LibraryDescriptor> libraries; + utils::file::FileMatcher(pattern.value()).forEachFile([&] (const std::string& dir, const std::string& filename) { Review comment: ~19560f3~ 02bab30 `utils::file::match` is just a quick and dirty implementation there. And one of the tricky things was realizing that an rvalue range does not satisfy viewable_range and therefore cannot be "piped" to view niebloids. edit: replaced with 02bab30 because I messed up the first dereference version and because most of our tested compilers lack concepts support -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
