[
https://issues.apache.org/jira/browse/NIFI-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15592118#comment-15592118
]
ASF GitHub Bot commented on NIFI-2115:
--------------------------------------
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/583
Hey @jvwing, this is really nice. Just a couple general comments...
I'm not sure we want to include all the System/Java version details in the
about dialog. The `AboutDTO` which had these items added will be available for
any user who has permissions to access the UI. I have concern allowing all
users who can access the UI to know the server's OS/architecture/version and
what vendor/version of Java is running. Including these items in the System
Diagnostics is good IMO as users need to be granted explicit permission for
viewing system level details.
Leaving the build details in the About Dialog is good IMO. I would suggest
that we use the `DateTimeAdapter` on the build timestamp field to be consistent
with other timestamps rendered throughout the UI. Since these only add a couple
rows, it may make sense to remove the toggle and make the dialog a little bit
taller.
Thoughts?
> Enhanced About Box Version Information
> --------------------------------------
>
> Key: NIFI-2115
> URL: https://issues.apache.org/jira/browse/NIFI-2115
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core UI, Tools and Build
> Affects Versions: 1.0.0
> Reporter: James Wing
> Assignee: James Wing
> Priority: Minor
> Attachments: screenshot-1-of-4-about-expands.png,
> screenshot-2-of-4-git-build.png, screenshot-3-of-4-release-build.png,
> screenshot-4-of-4-source-build.png
>
>
> The UI's About dialog and underlying API provide the version of NiFi, like
> "0.7.0-SNAPSHOT". For many bug reports and troubleshooting requests, this is
> not very precise, especially around rapidly changing code or
> platform-dependent behavior. It would help if NiFi captured and displayed
> additional information:
> * NiFi build commit hash
> * NiFi build branch
> * NiFi build date/time
> * Java Version
> * Java Vendor (Oracle, OpenJDK)
> * OS
> Then a simple copy/paste from the about box would provide very specific
> information about a particular NiFi installation and which code it was
> derived from.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
