exceptionfactory opened a new pull request #5361:
URL: https://github.com/apache/nifi/pull/5361
#### Description of PR
NIFI-8749 Removes implicit time zone conversion to GMT when parsing dates
and times from strings to objects. This addresses a latent issue in
`DataTypeUtils.getDateFormat()` leading to unexpected behavior in
record-oriented components and other date parsing capabilities.
This pull request includes the same commit as #5305 with additional changes
to `TestRecordPath` using an static value for `user.timezone`. Using a static
`user.timezone` value in `TestRecordPath` avoids localized build failures where
the system time zone causes test failures in time zone conversion. This
addresses the issue described in NIFI-9148.
Removing the implicit conversion to GMT restores standard behavior where
NiFi handles date parsing according to the system default time zone. This has
no impact when parsing timestamps containing an explicit time zone, but
addresses issues in components such as `PutDatabaseRecord` when parsing
timestamps without a time zone indicator in the string.
The current Expression Language Guide indicates that both the `format` and
`toDate` functions default to the local time zone when the second argument is
not specified. The Record Path Guide previously indicated a default time zone
of GMT for the `toDate` function, reflecting the actual behavior when support
for a time zone argument was introduced. Recent updates to PutDatabaseRecord in
NIFI-8223, released in NiFi 1.13.0, surfaced this implicit conversion issue
when handling timestamp inputs from Record Readers.
Changes include replacing the GMT Time Zone in
`DataTypeUtils.getDateFormat()` with the explicit default of
`TimeZone.getDefault()`. Additional updates include unit test adjustments in
order to conform expected values to meet the corrected behavior.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [X] Has your PR been rebased against the latest commit within the target
branch (typically `main`)?
- [ ] Is your initial contribution a single, squashed commit? _Additional
commits in response to PR reviewer feedback should be made on this branch and
pushed to allow change tracking. Do not `squash` or use `--force` when pushing
to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn
-Pcontrib-check clean install` at the root `nifi` folder?
- [X] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main
`LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main
`NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [X] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for
build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
