exceptionfactory commented on pull request #5363: URL: https://github.com/apache/nifi/pull/5363#issuecomment-912113112
Thanks for the feedback @emiliosetiadarma! Good catch on the class names, I made the adjustments you suggested and also added a note to the Administrator's Guide regarding commented file reference properties. I considered having `EncodedSensitivePropertyProvider` extend `AbstractSensitivePropertyProvider`, but since other classes handle instantiation differently and override the `getIdentifier` method in some cases, it did not seem like the best approach. Please let me know if you have any additional comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org