szaszm opened a new pull request #1171: URL: https://github.com/apache/nifi-minifi-cpp/pull/1171
- removed a few unnecessary `add_dependencies` calls in cmake: add_dependencies(A B) will wait for B to be built before starting to build A. In most cases, we only want to link them together, but we can build them in parallel. - reduced the number of catch2 main instances (TUs where CATCH_CONFIG_MAIN is defined). Compiling such a TU takes about 30-40sec. We already have a target with a catch2 main that we can link to test binaries, so I changed a few of them to link instead of instantiating another main. There were also cases where the tests were both linked to catch2 main and had CATCH_CONFIG_MAIN themselves, so I removed the unnecessary CATCH_CONFIG_MAIN TUs. - Opted out of some catch2 features to reduce compilation time: https://github.com/catchorg/Catch2/blob/v2.13.6/docs/configuration.md#other-toggles rough measurements of `make -j64` with a wide range of extensions enabled: main: 3:54 real 3m54.001s user 127m7.528s sys 6m44.876s this PR: 2:57 (20% faster) real 2m57.236s user 128m48.359s sys 6m50.702s this PR + #1165: 2:48 (30% faster) real 2m48.448s user 107m30.460s sys 6m0.179s Less parallel builds might benefit less from the changes, especially removal of add_dependencies, that only affected parallelization opportunities. --- Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically main)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] If applicable, have you updated the LICENSE file? - [x] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
