fgerlits commented on a change in pull request #1172: URL: https://github.com/apache/nifi-minifi-cpp/pull/1172#discussion_r716498144
########## File path: docker/test/integration/features/mqtt.feature ########## @@ -0,0 +1,66 @@ +Feature: Sending data to using MQTT streaming platform using PublishMQTT + In order to send and receive data via MQTT + As a user of MiNiFi + I need to have PublishMQTT and ConsumeMQTT processors + + Background: + Given the content of "/tmp/output" is monitored + + Scenario: A MiNiFi instance transfers data to an MQTT broker + Given a GetFile processor with the "Input Directory" property set to "/tmp/input" + And a file with the content "test" is present in "/tmp/input" + And a PublishMQTT processor set up to communicate with an MQTT broker instance + And a PutFile processor with the "Directory" property set to "/tmp/output" + And the "success" relationship of the GetFile processor is connected to the PublishMQTT + And the "success" relationship of the PublishMQTT processor is connected to the PutFile + + And an MQTT broker is set up in correspondence with the PublishMQTT + + When both instances start up + Then a flowfile with the content "test" is placed in the monitored directory in less than 60 seconds + And the MQTT broker has 1 log line matching "Received PUBLISH from .*testtopic.*\\(4 bytes\\)" + + Scenario: A MiNiFi instance tries to transfer data to a non-existent MQTT broker Review comment: OK, I get it -- if the processor can't connect to the broker, it won't even pick up any flow files from the queue. I would change the title of this scenario to better explain this, e.g. "If the MQTT broker does not exist, then no flow files are processed". This approach could be improved (e.g. with a configurable timeout), but definitely not in this pull request. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org