sedadgn commented on pull request #5458:
URL: https://github.com/apache/nifi/pull/5458#issuecomment-975207345


   > Hey @sedadgn! I've found one thing among the new changes after that I 
think we can wrap the things up.
   > 
   > Another thing. During the 2. review, an alternative solution came to my 
mind. Couldn't we spare the escaping part by making the separator itself 
configurable? That one feels a bit more robust for me. There is an example for 
that: 
https://nifi.apache.org/docs/nifi-docs/components/nifi-docs/components/org.apache.nifi/nifi-poi-nar/1.9.0/org.apache.nifi.processors.poi.ConvertExcelToCSVProcessor/index.html
 I understand that the PR has been open for more than a month now so I don't 
ask you to change the current behavior - unless you strongly agree -, just 
wanted to share that idea.
   
   Hello @nandorsoma 
   I think the solution is better. Strongly I agree :). I will implement. But I 
will need some time.
   Thank you
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to