[
https://issues.apache.org/jira/browse/NIFI-2928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15609016#comment-15609016
]
ASF GitHub Bot commented on NIFI-2928:
--------------------------------------
GitHub user olegz opened a pull request:
https://github.com/apache/nifi/pull/1160
NIFI-2928 added support to validate accessibility of the file system
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
NIFI-2928 polishing
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/olegz/nifi NIFI-2928
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1160.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1160
----
commit 662da5e42f0fc61ca8c7afc906b43fbc1fd4a386
Author: Oleg Zhurakousky <o...@suitcase.io>
Date: 2016-10-26T16:57:37Z
NIFI-2928 added support to validate accessibility of the file system
NIFI-2928 polishing
----
> FetchFile routes to not.found when it cannot determine whether or not the
> file exists
> -------------------------------------------------------------------------------------
>
> Key: NIFI-2928
> URL: https://issues.apache.org/jira/browse/NIFI-2928
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Affects Versions: 0.7.1
> Reporter: Christopher McDermott
> Assignee: Oleg Zhurakousky
> Fix For: 1.1.0
>
>
> I have a flow that reads files from an NFS volume. To simulate the NFS
> server being offline/unreachable I am using IP tables to block all TCP
> traffic between the NFS server and the host running NiFi.
> Trying to read files using FetchFile, I am seeing
> 2016-10-20 20:34:31,789 ERROR [Timer-Driven Process Thread-4]
> o.a.nifi.processors.standard.FetchFile
> FetchFile[id=9e642524-0e05-4d58-aabc-d6b49d687917] Could not fetch file
> /share/st5103/REDACTED from file system for
> StandardFlowFileRecord[uuid=1f88f322-57a2-4ac5-87df-d53fdd63d52c,claim=StandardContentClaim
> [resourceClaim=StandardResourceClaim[id=1476995181657-18524,
> container=default, section=92], offset=569544,
> length=745],offset=0,name=1248995905448067,size=745] because the file does
> not exist; routing to not.found
> The file is actually there, but of course it is inaccessible because the
> network traffic is blocked.
> I see the code is using {{File.exists()}}.
> This [bug|https://bugs.openjdk.java.net/browse/JDK-6191254] report suggest
> that it should instead use
> {{[File.toPath().checkAccess()|http://download.java.net/jdk7/archive/b123/docs/api/java/nio/file/Path.html#checkAccess(java.nio.file.AccessMode...)]}}
> {{[java.nio.Files.notExists()|http://docs.oracle.com/javase/7docs/api/java/nio/file/Files.html#notExists-java.nio.file.Path-java.nio.file.LinkOption...-]}}
> uses {{checkAccess()}} and might be a drop-in replacement.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
