joewitt commented on a change in pull request #5578:
URL: https://github.com/apache/nifi/pull/5578#discussion_r763426629
##########
File path:
nifi-nar-bundles/nifi-splunk-bundle/nifi-splunk-processors/src/main/java/org/apache/nifi/processors/splunk/GetSplunk.java
##########
@@ -105,6 +106,20 @@
.addValidator(StandardValidators.PORT_VALIDATOR)
.defaultValue("8089")
.build();
+ public static final PropertyDescriptor CONNECT_TIMEOUT = new
PropertyDescriptor.Builder()
+ .name("Connection Timeout")
+ .description("Max wait time for connection to the Splunk server.")
+ .required(true)
+ .defaultValue("5 secs")
+ .addValidator(StandardValidators.TIME_PERIOD_VALIDATOR)
+ .build();
+ public static final PropertyDescriptor READ_TIMEOUT = new
PropertyDescriptor.Builder()
+ .name("Read Timeout")
+ .description("Max wait time for response from the Splunk server.")
+ .required(true)
Review comment:
They should not be required and since we have a default they definitely
don't need to be provided.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
