kevdoran commented on a change in pull request #5563: URL: https://github.com/apache/nifi/pull/5563#discussion_r765838230
########## File path: c2/c2-protocol/c2-protocol-api/src/main/java/org/apache/nifi/c2/protocol/api/C2Heartbeat.java ########## @@ -0,0 +1,160 @@ +/* + * Apache NiFi - MiNiFi + * Copyright 2014-2018 The Apache Software Foundation + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.nifi.c2.protocol.api; + +import io.swagger.annotations.ApiModel; +import io.swagger.annotations.ApiModelProperty; +import java.io.Serializable; +import javax.xml.bind.annotation.XmlTransient; +import org.apache.commons.lang3.builder.EqualsBuilder; +import org.apache.commons.lang3.builder.HashCodeBuilder; + +/** + * TODO add Builder interface + */ +@ApiModel +public class C2Heartbeat implements Serializable { + private static final long serialVersionUID = -1168790962754919591L; + + // Internal, not part of REST API + private String identifier; + private Long created; Review comment: I think this was just for consistency with other timestamps in the c2 protocol. We made the decision in the c++ implementation to use milliseconds since epoch for all timestamps for the wire representation. That said, the in memory model for Java can use whatever class it wants so long as the to/from JSON logic encodes/decodes to a long. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
