adamdebreceni commented on a change in pull request #1225:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1225#discussion_r767695962
##########
File path: extensions/libarchive/BinFiles.h
##########
@@ -154,7 +154,7 @@ class BinManager {
void setMinEntries(uint32_t entries) {
minEntries_ = {entries};
}
- void setBinAge(uint64_t age) {
+ void setBinAge(std::chrono::milliseconds age) {
binAge_ = {age};
Review comment:
this kind of assignment was used to protect against accidental narrowing
conversions, since we use `std::chrono::milliseconds` now I think they are
unnecessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
