mattyb149 commented on a change in pull request #5612: URL: https://github.com/apache/nifi/pull/5612#discussion_r771740656
########## File path: c2/c2-protocol/c2-protocol-component-api/pom.xml ########## @@ -15,9 +15,9 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. --> -<project xmlns="https://maven.apache.org/POM/4.0.0"; - xmlns:xsi="https://www.w3.org/2001/XMLSchema-instance"; - xsi:schemaLocation="https://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> +<project xmlns="http://maven.apache.org/POM/4.0.0"; Review comment: These look like an IDE did that and IIRC we were supposed to have them use HTTPS? ########## File path: nifi-manifest/nifi-runtime-manifest/pom.xml ########## @@ -0,0 +1,155 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + http://www.apache.org/licenses/LICENSE-2.0 + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--> +<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + <parent> + <groupId>org.apache.nifi</groupId> + <artifactId>nifi-manifest</artifactId> + <version>1.16.0-SNAPSHOT</version> + </parent> + <artifactId>nifi-runtime-manifest</artifactId> + <packaging>jar</packaging> + + <properties> + <extension.manifest.unpack.dir>${project.build.directory}</extension.manifest.unpack.dir> + <build.properties.file>${project.build.directory}/classes/build.properties</build.properties.file> + <runtime.manifest.file>${project.build.directory}/classes/nifi-runtime-manifest.json</runtime.manifest.file> + <runtime.manifest.id>apache-nifi</runtime.manifest.id> + </properties> + + <dependencies> + <!-- Needed to unpack the extension-manifest.xml files during the build, marked as optional Review comment: I couldn't figure/track the Maven chain here, is there a chicken-and-egg-thing (with a pristine build environment) or is everything happening in the correct order? ########## File path: c2/c2-protocol/c2-protocol-component-api/src/main/java/org/apache/nifi/c2/protocol/component/api/ProcessorDefinition.java ########## @@ -85,4 +102,130 @@ public boolean getSupportsDynamicRelationships() { public void setSupportsDynamicRelationships(boolean supportsDynamicRelationships) { this.supportsDynamicRelationships = supportsDynamicRelationships; } + + @ApiModelProperty("Whether or not this processor should be triggered serially") + public boolean getTriggerSerially() { + return triggerSerially; + } + + public void setTriggerSerially(boolean triggerSerially) { + this.triggerSerially = triggerSerially; + } + + @ApiModelProperty("Whether or not this processor should be triggered when incoming queues are empty") + public boolean getTriggerWhenEmpty() { + return triggerWhenEmpty; + } + + public void setTriggerWhenEmpty(boolean triggerWhenEmpty) { + this.triggerWhenEmpty = triggerWhenEmpty; + } + + @ApiModelProperty("Whether or not this processor should be triggered when any destination queue has room") + public boolean getTriggerWhenAnyDestinationAvailable() { + return triggerWhenAnyDestinationAvailable; + } + + public void setTriggerWhenAnyDestinationAvailable(boolean triggerWhenAnyDestinationAvailable) { + this.triggerWhenAnyDestinationAvailable = triggerWhenAnyDestinationAvailable; + } + + @ApiModelProperty("Whether or not this processor supports batching") + public boolean getSupportsBatching() { + return supportsBatching; + } + + public void setSupportsBatching(boolean supportsBatching) { + this.supportsBatching = supportsBatching; + } + + @ApiModelProperty("Whether or not this processor supports event driven scheduling") + public boolean getSupportsEventDriven() { + return supportsEventDriven; + } + + public void setSupportsEventDriven(boolean supportsEventDriven) { + this.supportsEventDriven = supportsEventDriven; + } + + @ApiModelProperty("Whether or not this processor should be scheduled only on the primary node in a cluster") + public boolean getPrimaryNodeOnly() { + return primaryNodeOnly; + } + + public void setPrimaryNodeOnly(boolean primaryNodeOnly) { + this.primaryNodeOnly = primaryNodeOnly; + } + + @ApiModelProperty("Whether or not this processor is considered side-effect free") Review comment: Do we want more info here, either what side-effect-free means or a link to some other docs? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
