adamdebreceni commented on a change in pull request #1238:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1238#discussion_r783838662
##########
File path: extensions/sql/data/SQLIdentifier.h
##########
@@ -19,18 +19,40 @@
#pragma once
#include <string>
-#include <vector>
+#include <functional>
-namespace org {
-namespace apache {
-namespace nifi {
-namespace minifi {
-namespace utils {
+namespace org::apache::nifi::minifi::sql {
-std::vector<std::string> inputStringToList(const std::string& str);
+class SQLIdentifier {
Review comment:
I think we can constrain it to columns for now, renamed it to
`SQLColumnIdentifier` (if we need to use something like this for tables/others
we can revisit this)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
