pvillard31 commented on pull request #5530: URL: https://github.com/apache/nifi/pull/5530#issuecomment-1014770503
Thanks @simonbence - the catch you describe is perfectly fine and is something I'm expecting to be honest. Users can easily remove this field if this is problematic for them. I made another round of testing and this is working perfectly (at least, compared to my expectations :)). A follow up improvement would be to submit a pull request against the third party library so that we can get the reason why the parsing failed for a given record (this is currently something we can only get by looking in the logs). Maybe I'll find the motivation to look into this in the future. From a pure feature point of view, I'm a +1 with the pull request given my tests. @exceptionfactory do you want to have another look at this? any recommendations/comments from a code perspective? are you with the dep. updates? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
