guimou commented on pull request #5684: URL: https://github.com/apache/nifi/pull/5684#issuecomment-1018849385
Hi @dmnewber! The idea of creating the openshift folders alongside the docker/dockerhub ones (btw naming and structure is not really consistent for those) was to minimize coupling, in the sense that I did not want to "get in the way" (I was not even sure the project would be interested by this). In my idea, people would be able to build the images themselves, or we could have an external automated build process generating these specific/custom images without putting too much burden on the project. Having their definitions integrated into the NiFi code would make it easier to find them though, even if people had to build themselves. Now, if the project thinks it's a good idea and is keen to integrate those images, I could change the approach and extend the maven builds with openshift profiles that would source their files from the already existing docker/dockerhub folders, as well as from the openshift one, but that would then only contain its specific files. The thing I'm struggling with though is that the way the different images are built (nifi, registry, toolkit) is not really consistent (for registry for example it does not seem to be a maven build at all, whereas in nifi you find two different things, dockerhub and dockermaven...), so I'm not sure how I should do this... Another less intrusive option would be to simply add instructions/script in the parent folder and build directly from there. Like this, the build context would authorize to pick files from diffent subfolders and minimize duplication. This would also allow to provide only "recipes" for OpenShift, but not integrate the full build and have to determine where to put and how to name those images. I'm open to any suggestion, whatever is the simple for the project and the users! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
