adamdebreceni commented on a change in pull request #1242:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1242#discussion_r790845276
##########
File path: extensions/azure/storage/AzureDataLakeStorage.cpp
##########
@@ -20,11 +20,43 @@
#include "AzureDataLakeStorage.h"
+#include <regex>
+#include <string_view>
+
#include "AzureDataLakeStorageClient.h"
#include "io/StreamPipe.h"
+#include "utils/file/FileUtils.h"
+#include "utils/StringUtils.h"
+#include "utils/gsl.h"
+#include "utils/GeneralUtils.h"
namespace org::apache::nifi::minifi::azure::storage {
+namespace {
+bool matchesPathFilter(std::string_view base_directory, const std::string&
path_filter, std::string path) {
Review comment:
we could propagate the `std::string -> std::regex` conversion up the
chain (make it a responsibility of `onSchedule`) and accept an
`std::optional<std::regex>` here, in case of an invalid regex expression we
would get immediate feedback in `onSchedule` instead of on every trigger
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
