lordgamez commented on a change in pull request #1251:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1251#discussion_r795599349
##########
File path: extensions/sftp/tests/PutSFTPTests.cpp
##########
@@ -504,7 +504,9 @@ TEST_CASE_METHOD(PutSFTPTestsFixture, "PutSFTP set mtime",
"[PutSFTP]") {
testController.runSession(plan, true);
testFile("nifi_test/tstFile1.ext", "content 1");
- testModificationTime("nifi_test/tstFile1.ext", 3000000000LL);
+ using namespace std::chrono; // NOLINT(build/namespaces)
Review comment:
nitpick: I would use `std::literals::chrono_literals` namespace here
instead as we allow that in the linter and use the fully qualified namespaces
for the type declaration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
