szaszm commented on a change in pull request #1249:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1249#discussion_r800672312
##########
File path: libminifi/include/io/ClientSocket.h
##########
@@ -137,8 +137,8 @@ class Socket : public BaseStream {
* @param buflen
* @param retrieve_all_bytes determines if we should read all bytes before
returning
*/
- size_t read(uint8_t *buf, size_t buflen) override {
- return read(buf, buflen, true);
+ size_t read(gsl::span<std::byte> buf) override {
+ return read(buf, false);
Review comment:
Looks like a mistake, changed back to true in
[30de0dc](https://github.com/apache/nifi-minifi-cpp/pull/1249/commits/30de0dc2abaed028ebf8ebb08be2bd9fd86edb52)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
