mtien-apache commented on a change in pull request #56:
URL: https://github.com/apache/nifi-site/pull/56#discussion_r801021704
##########
File path: src/pages/markdown/fds-release-guide.md
##########
@@ -409,11 +466,11 @@ After the vote is complete and the release is approved,
these steps complete the
Apache NiFi Flow Design System is an atomic reusable platform for
providing a consistent set of UI/UX components for open source friendly web
applications to consume.
- More details on Apache NiFi can be found here:
+ More details on Apache NiFi FLow Design System can be found here:
Review comment:
```suggestion
More details on Apache NiFi Flow Design System can be found here:
```
##########
File path: src/pages/markdown/fds-release-guide.md
##########
@@ -192,7 +193,21 @@ running at [http://localhost:8080](http://localhost:8080).
$ shasum -a 512 nifi-fds-${NIFI_FDS_VERSION}-source-release.zip | cut
-d" " -f1 > nifi-fds-${NIFI_FDS_VERSION}-source-release.zip.sha512
```
-1. Commit the source release along with their hashes and signatures to
`https://dist.apache.org/repos/dist/dev/nifi-fds/nifi-fds-${NIFI_FDS_VERSION}`.
+1. Commit the source release along with their hashes and signatures to
`https://dist.apache.org/repos/dist/dev/nifi/nifi-fds/nifi-fds-${NIFI_FDS_VERSION}`.
+ 1. Checkout the Apache dist dev svn repo locally using your Apache
credentials
+ ```
+ $ svn checkout https://dist.apache.org/repos/dist/dev/nifi
+ ```
+ 1. Create the directory for nifi-fds-${NIFI_FDS_VERSION}.
+ 1. Copy the zipped source release and its corresponding signatures and
hashes into the new directory.
+ 1. Add the commit.
+ ```
+ $ svn add ./nifi-fds-2.0.0/*
Review comment:
Should this be `0.2.0`?
##########
File path: src/pages/markdown/fds-release-guide.md
##########
@@ -147,42 +147,43 @@ the NiFi wiki.
1. Startup and test the demo application from the target source folder. After
a few seconds, NiFi FDS should be up and
running at [http://localhost:8080](http://localhost:8080).
```
- $ cd target/
+ $ cd target/frontend-working-directory
$ npm start
```
1. Evaluate and ensure the appropriate license headers are present on all
source files.
1. Ensure LICENSE and NOTICE files are complete and accurate. (Developers
should always be keeping these up to date as
they go along adding source and modifying dependencies to keep this burden
manageable.)
+1. Verify that no vulnerabilities exist in any javascript module dependencies
(requires npm 6+).
+ ```
+ $ npm audit
+ ```
### Step 3. Perform the release (RM)
1. Now its time to prepare the release. Manually update the version number in
Review comment:
Minor typo
```suggestion
1. Now it's time to prepare the release. Manually update the version number
in
```
##########
File path: src/pages/markdown/fds-release-guide.md
##########
@@ -339,51 +354,93 @@ After the vote is complete and the release is approved,
these steps complete the
[comment]: <> (some of these steps need further detail and/or examples)
-1. Move convenience binaries and related artifacts from dist/dev to
dist/release:
+1. Move the source code and related artifacts from dist/dev to dist/release:
+ ```
+ $ svn move -m "NIFI-FDS-${NIFI_FDS_VERSION}"
https://dist.apache.org/repos/dist/dev/nifi/nifi-fds/nifi-fds-${NIFI_FDS_VERSION}
https://dist.apache.org/repos/dist/release/nifi/nifi-fds/nifi-fds-${NIFI_FDS_VERSION}
```
- $ svn move -m "NIFI-FDS-${JIRA_TICKET}"
https://dist.apache.org/repos/dist/dev/nifi/nifi-fds/nifi-fds-${NIFI_FDS_VERSION}
https://dist.apache.org/repos/dist/release/nifi/nifi-fds/nifi-fds-${NIFI_FDS_VERSION}
+1. Manually update the version number to the next snapshot
+ ```bash
+ $ git checkout NIFI-FDS-${NIFI_FDS_VERSION}-RC${RC}
+ ```
+ update the version number to the next `${NIFI_FDS_VERSION}-SNAPSHOT` in
Review comment:
```suggestion
Update the version number to the next `${NIFI_FDS_VERSION}-SNAPSHOT` in
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
