[ 
https://issues.apache.org/jira/browse/MINIFICPP-1741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ádám Markovics updated MINIFICPP-1741:
--------------------------------------
    Description: 
To run the docker-based integration tests, you
 # run {{cmake}} with some set of flags to enable or disable certain features;
 # run {{make docker}} to create the minifi image;
 # run {{make docker-verify}} to run the tests.

The problem is that the image created in (2) will only contain the features 
selected in (1), but (3) will run all tests, even those which require a feature 
not included in the image – these tests will fail.

We should find a way to only run tests for features enabled in the {{cmake}} 
step, as it is done in the case of unit tests.

We should have 3 options of running docker tests:
# Run all of them
# Run only the ones whose flags are enabled in CMake (this should be the 
default)
# Run only one explicity asked by the user (useful during development)

  was:
To run the docker-based integration tests, you
 # run {{cmake}} with some set of flags to enable or disable certain features;
 # run {{make docker}} to create the minifi image;
 # run {{make docker-verify}} to run the tests.

The problem is that the image created in (2) will only contain the features 
selected in (1), but (3) will run all tests, even those which require a feature 
not included in the image – these tests will fail.

We should find a way to only run tests for features enabled in the {{cmake}} 
step, as it is done in the case of unit tests.


> Docker-based integration tests should only test features which are available
> ----------------------------------------------------------------------------
>
>                 Key: MINIFICPP-1741
>                 URL: https://issues.apache.org/jira/browse/MINIFICPP-1741
>             Project: Apache NiFi MiNiFi C++
>          Issue Type: Improvement
>            Reporter: Ferenc Gerlits
>            Priority: Minor
>              Labels: MiNiFi-CPP-Hygiene
>
> To run the docker-based integration tests, you
>  # run {{cmake}} with some set of flags to enable or disable certain features;
>  # run {{make docker}} to create the minifi image;
>  # run {{make docker-verify}} to run the tests.
> The problem is that the image created in (2) will only contain the features 
> selected in (1), but (3) will run all tests, even those which require a 
> feature not included in the image – these tests will fail.
> We should find a way to only run tests for features enabled in the {{cmake}} 
> step, as it is done in the case of unit tests.
> We should have 3 options of running docker tests:
> # Run all of them
> # Run only the ones whose flags are enabled in CMake (this should be the 
> default)
> # Run only one explicity asked by the user (useful during development)



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to