martinzink commented on pull request #1261: URL: https://github.com/apache/nifi-minifi-cpp/pull/1261#issuecomment-1035113432
> And another question: does this change benefit the codebase aside from the upcoming GCS extension? E.g. do we save compilation time? If not, maybe it would be better for GCS to not rely on these utilities, or only depend on a limited set of them, and keep the extra complexity of dealing with Google's BS inside the extension. I don't expect many too many dependencies in the future that mandate their own test framework. I dont think that there is measurable difference if any. But I do think this improves the codebase because it removes an unneccessary direct dependency. The utilities in TestBase.h and SingleInputTestController.h dont rely on Catch2 so this change is really an _include what you use_ refactor, because I think our catch tests should include the catch headers and not get them indirectly from TestBase.h Also without TestBase.h I think the quality of the GCS tests would greatly decrease (or bring in some code duplication) Besides the GCS extension we could also use gtest to create [death tests](https://google.github.io/googletest/advanced.html#death-tests) (catch2 doesnt support those yet iirc) Overall I might agree that the upside is not that great, but I dont really see a downside to this change either. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
