turcsanyip commented on a change in pull request #5692:
URL: https://github.com/apache/nifi/pull/5692#discussion_r804880705
##########
File path:
nifi-nar-bundles/nifi-standard-services/nifi-dbcp-service-bundle/nifi-dbcp-service/src/main/java/org/apache/nifi/dbcp/DBCPConnectionPool.java
##########
@@ -81,30 +81,30 @@
protected static final String SENSITIVE_PROPERTY_PREFIX = "SENSITIVE.";
/**
- * Copied from {@link GenericObjectPoolConfig.DEFAULT_MIN_IDLE} in
Commons-DBCP 2.7.0
+ * Copied from {@link GenericObjectPoolConfig#DEFAULT_MIN_IDLE} in
Commons-DBCP 2.7.0
*/
- private static final String DEFAULT_MIN_IDLE = "0";
+ protected static final String DEFAULT_MIN_IDLE = "0";
Review comment:
It is unused now because `GenericObjectPoolConfig.DEFAULT_MIN_IDLE` is
directly referenced in the `PropertyDescriptor`.
Not clear why these constants were copied from `GenericObjectPoolConfig` but
`DEFAULT_MAX_IDLE` could also be used directly. Maybe others too.
I'm not in favour of changing them, I'm rather unsure if DEFAULT_MIN_IDLE
should be changed at all.
The constants are not referenced any more in the subclass directly, so they
could remain `private` I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
