lordgamez commented on a change in pull request #1253:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1253#discussion_r806563819



##########
File path: libminifi/include/properties/Configuration.h
##########
@@ -99,6 +139,30 @@ class Configuration : public Properties {
   static constexpr const char *minifi_disk_space_watchdog_interval = 
"minifi.disk.space.watchdog.interval";
   static constexpr const char *minifi_disk_space_watchdog_stop_threshold = 
"minifi.disk.space.watchdog.stop.threshold";
   static constexpr const char *minifi_disk_space_watchdog_restart_threshold = 
"minifi.disk.space.watchdog.restart.threshold";
+
+  // JNI options
+  static constexpr const char *nifi_framework_dir = "nifi.framework.dir";
+  static constexpr const char *nifi_jvm_options = "nifi.jvm.options";
+  static constexpr const char *nifi_nar_directory = "nifi.nar.directory";
+  static constexpr const char *nifi_nar_deploy_directory = 
"nifi.nar.deploy.directory";
+
+  // Log options
+  static constexpr const char *nifi_log_spdlog_pattern = 
"nifi.log.spdlog.pattern";
+  static constexpr const char *nifi_log_spdlog_shorten_names = 
"nifi.log.spdlog.shorten_names";
+  static constexpr const char *nifi_log_appender_rolling = 
"nifi.log.appender.rolling";
+  static constexpr const char *nifi_log_appender_rolling_directory = 
"nifi.log.appender.rolling.directory";
+  static constexpr const char *nifi_log_appender_rolling_file_name = 
"nifi.log.appender.rolling.file_name";
+  static constexpr const char *nifi_log_appender_rolling_max_files = 
"nifi.log.appender.rolling.max_files";
+  static constexpr const char *nifi_log_appender_rolling_max_file_size = 
"nifi.log.appender.rolling.max_file_size";
+  static constexpr const char *nifi_log_appender_stdout = 
"nifi.log.appender.stdout";
+  static constexpr const char *nifi_log_appender_stderr = 
"nifi.log.appender.stderr";
+  static constexpr const char *nifi_log_appender_null = 
"nifi.log.appender.null";
+  static constexpr const char *nifi_log_appender_syslog = 
"nifi.log.appender.syslog";
+  static constexpr const char *nifi_log_logger_root = "nifi.log.logger.root";
+  static constexpr const char *nifi_log_compression_cached_log_max_size = 
"nifi.log.compression.cached.log.max.size";
+  static constexpr const char *nifi_log_compression_compressed_log_max_size = 
"nifi.log.compression.compressed.log.max.size";
+
+  MINIFIAPI static const std::vector<core::ConfigurationProperty> 
CONFIGURATION_PROPERTIES;

Review comment:
       The reason the vector was introduced to be able to iterate through all 
the available properties to be added to the agent manifest.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to