szaszm commented on a change in pull request #1252:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1252#discussion_r813057373
##########
File path: libminifi/include/FlowController.h
##########
@@ -87,13 +91,8 @@ class FlowController : public
core::controller::ForwardingControllerServiceProvi
return this->provenance_repo_;
}
- // Get the flowfile repository
- virtual std::shared_ptr<core::Repository> getFlowFileRepository() {
- return this->flow_file_repo_;
- }
-
// Load flow xml from disk, after that, create the root process group and
its children, initialize the flows
- virtual void load(const std::shared_ptr<core::ProcessGroup> &root = nullptr,
bool reload = false);
+ virtual void load(std::unique_ptr<core::ProcessGroup>&& root = nullptr, bool
reload = false);
Review comment:
I mean the parameter is moved into the function and either the
implementation moves from it or it's destructed. In the rvalue ref case, if the
implementation doesn't move from the reference, then the object stays intact.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
