fgerlits commented on a change in pull request #1253:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1253#discussion_r816654752
##########
File path: libminifi/include/core/Property.h
##########
@@ -467,6 +468,16 @@ class ConstrainedProperty : public
std::enable_shared_from_this<ConstrainedPrope
friend class PropertyBuilder;
};
+struct ConfigurationProperty {
+ explicit ConfigurationProperty(std::string_view name_,
gsl::not_null<PropertyValidator*> validator_ =
gsl::make_not_null(StandardValidators::get().VALID_VALIDATOR.get()))
+ : name(name_),
+ validator(validator_) {
Review comment:
The style guide says not to use `_` for parameters, either, so we are
deviating from it in either case. I think using `_` for the struct members is
the smaller deviation, and fits the rest of our code more. But if you like it
better this way, that's fine, too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
