fgerlits commented on a change in pull request #1270:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1270#discussion_r816920859
##########
File path: docker/test/integration/minifi/core/DockerTestCluster.py
##########
@@ -34,6 +34,15 @@ def get_stdout_encoding():
return encoding
def get_app_log(self, container_name):
+ type = self.containers[container_name].type()
+ if type == 'docker container':
+ return self.__get_app_log_from_docker_container(container_name)
+ elif type == 'direct':
+ return self.containers[container_name].get_app_log()
+ else:
+ raise Exception("Unexpected container type '%s'" % type)
Review comment:
Part of the problem is that we have our own `minifi.core.Container` (and
derived classes), and the docker client's `docker.models.Container`, and we
call both "container".
The difference here is whether we get the logs from the
`docker.models.Container` contained in the `minifi.core.Container`, or directly
from the `minifi.core.Container`, using its `get_app_log()` method. This could
be used more generally than Kubernetes or Kind, so "kind cluster container" is
too specific.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
