exceptionfactory commented on pull request #5844:
URL: https://github.com/apache/nifi/pull/5844#issuecomment-1060846656


   Concurring with @MikeThomsen, the approach implemented in the pull request 
does not appear to be a good fit for a community-supported component.  There is 
a notable amount of code specific to MongoDB, which looks like it could be 
refactored to leverage the existing `MongoDBControllerService`.  In light of 
existing components capable of interacting with MongoDB, it seems like it would 
be better to implement a more focused processor to handle NGSI event 
conversion, as one possible approach.
   
   As a potential way forward, it would be helpful to write up a basic design 
in the associated Jira issue and solicit feedback using the mailing lists.  
That would help focus the approach, and provide opportunity to evaluate the 
conceptual implementation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to