Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/50#discussion_r86620366
--- Diff:
minifi-commons/minifi-commons-schema/src/main/java/org/apache/nifi/minifi/commons/schema/RemoteProcessingGroupSchema.java
---
@@ -50,17 +48,18 @@
public RemoteProcessingGroupSchema(Map map) {
name = getRequiredKeyAsType(map, NAME_KEY, String.class,
REMOTE_PROCESSING_GROUPS_KEY);
- url = getRequiredKeyAsType(map, URL_KEY, String.class,
REMOTE_PROCESSING_GROUPS_KEY);
- inputPorts = convertListToType(getRequiredKeyAsType(map,
INPUT_PORTS_KEY, List.class, REMOTE_PROCESSING_GROUPS_KEY), "input port",
RemoteInputPortSchema.class, INPUT_PORTS_KEY);
+ String wrapperName = "RemoteProcessingGroup(name:
{name})".replace("{name}", StringUtil.isNullOrEmpty(name) ? "unknown" : name);
--- End diff --
This may be a basic question but why use ".replace" (which compiles a
pattern) instead of just doing string concatenation?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
