markap14 commented on code in PR #5931:
URL: https://github.com/apache/nifi/pull/5931#discussion_r844439508
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/java/org/apache/nifi/integration/versioned/ImportFlowIT.java:
##########
@@ -511,45 +511,45 @@ public void
testUpdateFlowWithModifyingConnectionDeletingAndMovingPort() {
final ProcessGroup groupA = createProcessGroup("group-a-id", "Group
A", getRootGroup());
//Create Process Group B under Process Group A
- final ProcessGroup groupB = createProcessGroup("group-b-id", "Group
B", groupA);
+ final ProcessGroup groupBunderA = createProcessGroup("group-b-id",
"Group B", groupA);
//Add Input port under Process Group B
- final Port inputPort =
getFlowController().getFlowManager().createLocalInputPort("input-port-id",
"Input Port");
- groupB.addInputPort(inputPort);
+ final Port inputPortBThenStayThenDelete =
getFlowController().getFlowManager().createLocalInputPort("input-port-id",
"Input Port");
+ groupBunderA.addInputPort(inputPortBThenStayThenDelete);
//Add Processor 1 under Process Group A
- final ProcessorNode processor1 =
createProcessorNode(GenerateProcessor.class, groupA);
+ final ProcessorNode processorA1 =
createProcessorNode(GenerateProcessor.class, groupA);
//Add Processor 2 under Process Group A
- final ProcessorNode processor2 =
createProcessorNode(GenerateProcessor.class, groupA);
+ final ProcessorNode processorA2 =
createProcessorNode(GenerateProcessor.class, groupA);
//Add Output Port under Process Group A
- final Port outputPort =
getFlowController().getFlowManager().createLocalOutputPort("output-port-id",
"Output Port");
- groupA.addOutputPort(outputPort);
+ final Port outputPortAThenB =
getFlowController().getFlowManager().createLocalOutputPort("output-port-id",
"Output Port");
+ groupA.addOutputPort(outputPortAThenB);
//Connect Processor 1 and Output Port as Connection 1
- final Connection connection1 = connect(groupA, processor1, outputPort,
processor1.getRelationships());
+ final Connection connectionProcessorA1ToOutputPortAThenProcessorA2 =
connect(groupA, processorA1, outputPortAThenB, processorA1.getRelationships());
//Connect Processor 1 and Input Port as Connection 2
- final Connection connection2 = connect(groupA, processor1, inputPort,
processor1.getRelationships());
+ final Connection connectionProcessorA1ToInputPortBThenStayThenDelete =
connect(groupA, processorA1, inputPortBThenStayThenDelete,
processorA1.getRelationships());
Review Comment:
Why the verbose naming of variables here? The variable name should be
concise but description of what the object is. But not how it's going to be
used. So I'm good with renaming to `connectionProcessorA1ToInputPortB` (though
I personally don't think it's necessary, but I have no problem with it). But
the `...ThenStayThenDelete` I do not think makes sense.
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/java/org/apache/nifi/integration/versioned/ImportFlowIT.java:
##########
@@ -511,45 +511,45 @@ public void
testUpdateFlowWithModifyingConnectionDeletingAndMovingPort() {
final ProcessGroup groupA = createProcessGroup("group-a-id", "Group
A", getRootGroup());
//Create Process Group B under Process Group A
- final ProcessGroup groupB = createProcessGroup("group-b-id", "Group
B", groupA);
+ final ProcessGroup groupBunderA = createProcessGroup("group-b-id",
"Group B", groupA);
//Add Input port under Process Group B
- final Port inputPort =
getFlowController().getFlowManager().createLocalInputPort("input-port-id",
"Input Port");
- groupB.addInputPort(inputPort);
+ final Port inputPortBThenStayThenDelete =
getFlowController().getFlowManager().createLocalInputPort("input-port-id",
"Input Port");
+ groupBunderA.addInputPort(inputPortBThenStayThenDelete);
//Add Processor 1 under Process Group A
- final ProcessorNode processor1 =
createProcessorNode(GenerateProcessor.class, groupA);
+ final ProcessorNode processorA1 =
createProcessorNode(GenerateProcessor.class, groupA);
//Add Processor 2 under Process Group A
- final ProcessorNode processor2 =
createProcessorNode(GenerateProcessor.class, groupA);
+ final ProcessorNode processorA2 =
createProcessorNode(GenerateProcessor.class, groupA);
//Add Output Port under Process Group A
- final Port outputPort =
getFlowController().getFlowManager().createLocalOutputPort("output-port-id",
"Output Port");
- groupA.addOutputPort(outputPort);
+ final Port outputPortAThenB =
getFlowController().getFlowManager().createLocalOutputPort("output-port-id",
"Output Port");
+ groupA.addOutputPort(outputPortAThenB);
//Connect Processor 1 and Output Port as Connection 1
- final Connection connection1 = connect(groupA, processor1, outputPort,
processor1.getRelationships());
+ final Connection connectionProcessorA1ToOutputPortAThenProcessorA2 =
connect(groupA, processorA1, outputPortAThenB, processorA1.getRelationships());
//Connect Processor 1 and Input Port as Connection 2
- final Connection connection2 = connect(groupA, processor1, inputPort,
processor1.getRelationships());
+ final Connection connectionProcessorA1ToInputPortBThenStayThenDelete =
connect(groupA, processorA1, inputPortBThenStayThenDelete,
processorA1.getRelationships());
Review Comment:
Why the verbose naming of variables here? The variable name should be
concise but description of what the object is. But not how it's going to be
used. So I'm good with renaming to `connectionProcessorA1ToInputPortB` (though
I personally don't think it's necessary, but I have no problem with it). But
the `...ThenStayThenDelete` I do not think makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
