[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1300: MINIFICPP-1675 Use regex.h instead of std::regex when using libstdc++

[GitBox]

lordgamez commented on code in PR #1300:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1300#discussion_r856212180


##########
extensions/standard-processors/tests/unit/ExtractTextTests.cpp:
##########
@@ -180,3 +181,36 @@ TEST_CASE("Test usage of ExtractText in regex mode", 
"[extracttextRegexTest]") {
 
   LogTestController::getInstance().reset();
 }
+
+#ifndef NO_MORE_REGFREEE

Review Comment:
   Good catch, it was turned off while testing locally, I readded it in 
affce89dfb183b10598bf0e8a4351a0e92db3fb2



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org