Github user mattyb149 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1002#discussion_r87074726
  
    --- Diff: 
nifi-api/src/main/java/org/apache/nifi/components/AbstractConfigurableComponent.java
 ---
    @@ -91,7 +91,9 @@ private PropertyDescriptor getPropertyDescriptor(final 
PropertyDescriptor specDe
                         value = descriptor.getDefaultValue();
                     }
                     if (value == null && descriptor.isRequired()) {
    -                    results.add(new 
ValidationResult.Builder().valid(false).input(null).subject(descriptor.getName()).explanation(descriptor.getName()
 + " is required").build());
    +                    ValidationResult.Builder builder = new 
ValidationResult.Builder().valid(false).input(null).subject(descriptor.getDisplayName());
    --- End diff --
    
    Shouldn't the setting of subject to getDisplayName() only be done if it is 
not null (like you've done in the next line down)?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to