exceptionfactory commented on code in PR #5868:
URL: https://github.com/apache/nifi/pull/5868#discussion_r860027890
##########
nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/pubsub/AbstractGCPubSubProcessor.java:
##########
@@ -58,6 +73,19 @@ public abstract class AbstractGCPubSubProcessor extends
AbstractGCPProcessor imp
private static final Set<Relationship> relationships =
Collections.unmodifiableSet(new HashSet<>(Arrays.asList(REL_SUCCESS,
REL_FAILURE)));
+ @Override
+ public List<PropertyDescriptor> getSupportedPropertyDescriptors() {
+ return Collections.unmodifiableList(Arrays.asList(
+ PROJECT_ID,
+ GCP_CREDENTIALS_PROVIDER_SERVICE,
+ PROXY_HOST,
+ PROXY_PORT,
+ HTTP_PROXY_USERNAME,
+ HTTP_PROXY_PASSWORD,
Review Comment:
Thanks for the link, but yes, removing the individual property descriptors
and just using the configuration service simplifies the changes. If there is
some other use case that necessitates individual properties, that could be
considered separately, but starting with just the proxy configuration service
property avoids introducing more properties.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
