[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1316: MINIFICPP-1687 Signal error on UUID collision

[GitBox]

lordgamez commented on code in PR #1316:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1316#discussion_r861558365


##########
libminifi/include/core/yaml/YamlConfiguration.h:
##########
@@ -277,6 +278,7 @@ class YamlConfiguration : public FlowConfiguration {
    * @return         the parsed or generated UUID string
    */
   std::string getOrGenerateId(const YAML::Node& yamlNode, const std::string& 
idField = "id");
+  std::string getRequiredIdField(const YAML::Node& yaml_node, std::string_view 
yaml_section = "", std::string error_message = "");

Review Comment:
   Replaced the error_message string to `std::string_view` int required field 
checks in 3bdcc32d44536916be6102c6e2b17dc67c7975bd



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org