Github user brosander commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/51#discussion_r87225923
--- Diff:
minifi-bootstrap/src/main/java/org/apache/nifi/minifi/bootstrap/RunMiNiFi.java
---
@@ -143,11 +145,18 @@
private volatile Set<Future<?>> loggingFutures = new HashSet<>(2);
private volatile int gracefulShutdownSeconds;
- private Set<ConfigurationChangeNotifier> changeNotifiers;
private Set<PeriodicStatusReporter> periodicStatusReporters;
+ private ConfigurationChangeCoordinator changeCoordinator;
private MiNiFiConfigurationChangeListener changeListener;
+ private volatile ByteBuffer currentConfigFile;
+
+ @Override
+ public ByteBuffer getConfigFile() {
+ return currentConfigFile;
--- End diff --
Can we make a defensive copy or provide an immutable value here? I'm
worried about multiple callers getting a stateful object.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
