lordgamez commented on code in PR #1330: URL: https://github.com/apache/nifi-minifi-cpp/pull/1330#discussion_r872128399
########## .clang-tidy: ########## @@ -0,0 +1,2 @@ +Checks: 'boost*,bugprone*,cert*,portability*,-clang-analyzer-optin.cplusplus.VirtualCall,-bugprone-narrowing-conversions,-bugprone-implicit-widening-of-multiplication-result,-bugprone-macro-parentheses,-bugprone-easily-swappable-parameters,-bugprone-exception-escape,-cert-err58-cpp,-cert-err33-c' Review Comment: The `cert-err58-cpp` check was disabled because it gave a warning for all `REGISTER_RESOURCE` macro usages and for all initialization of static processor properties (`initialization of '<Property or Processor_registrar>' with static storage duration may throw an exception that cannot be caught [cert-err58-cpp]`) and it didn't seem viable to change those. The `bugprone-macro-parentheses` check was disabled because it gave a warning a huge number of times without any indication of the filename or the line where it was found: ``` warning: macro replacement list should be enclosed in parentheses [bugprone-macro-parentheses] ``` As for the other checks I created a seperate Jira ticket [MINIFICPP-1833](https://issues.apache.org/jira/browse/MINIFICPP-1833) to evaluate each check group to see which ones should be integrated and fix the existing issues before adding them to the CI. This jira ticket can still be broken up further if needed, because I think it can effect too many files at once to fix all the issues. But this list is quite useful as integration candidates, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
