[ https://issues.apache.org/jira/browse/NIFI-1002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15651932#comment-15651932 ]
ASF GitHub Bot commented on NIFI-1002: -------------------------------------- Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/1184#discussion_r87268737 --- Diff: nifi-nar-bundles/nifi-websocket-bundle/nifi-websocket-processors/src/main/java/org/apache/nifi/processors/websocket/AbstractWebSocketProcessor.java --- @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.nifi.processors.websocket; + +import org.apache.nifi.components.PropertyDescriptor; +import org.apache.nifi.logging.ComponentLog; +import org.apache.nifi.processor.AbstractSessionFactoryProcessor; +import org.apache.nifi.processor.ProcessContext; +import org.apache.nifi.processor.ProcessSession; +import org.apache.nifi.processor.ProcessSessionFactory; +import org.apache.nifi.processor.ProcessorInitializationContext; +import org.apache.nifi.processor.exception.ProcessException; +import org.apache.nifi.websocket.WebSocketConfigurationException; +import org.apache.nifi.websocket.WebSocketService; + +import java.io.IOException; +import java.util.ArrayList; +import java.util.List; + +public abstract class AbstractWebSocketProcessor extends AbstractSessionFactoryProcessor { + + public static final String ATTR_WS_CS_ID = "websocket.controller.service.id"; + public static final String ATTR_WS_SESSION_ID = "websocket.session.id"; + public static final String ATTR_WS_ENDPOINT_ID = "websocket.endpoint.id"; + public static final String ATTR_WS_FAILURE_DETAIL = "websocket.failure.detail"; + public static final String ATTR_WS_MESSAGE_TYPE = "websocket.message.type"; + public static final String ATTR_WS_LOCAL_ADDRESS = "websocket.local.address"; + public static final String ATTR_WS_REMOTE_ADDRESS = "websocket.remote.address"; + + static List<PropertyDescriptor> getAbstractPropertyDescriptors(){ + final List<PropertyDescriptor> descriptors = new ArrayList<>(); + return descriptors; --- End diff -- I am not sure I understand this code 1. For each call you create a new List 2. It's always empty Could you please clarify? > support for Listen WebSocket processor > --------------------------------------- > > Key: NIFI-1002 > URL: https://issues.apache.org/jira/browse/NIFI-1002 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions > Affects Versions: 0.4.0 > Reporter: sumanth chinthagunta > Priority: Minor > Labels: newbie > > A WebSocket listen processor will be helpful for IoT data ingestion. > I am playing with embedded Vert.X for WebSocket and also ability to put > FlowFiles back to WebSocket client via Vert.X EventBus. > https://github.com/xmlking/nifi-websocket > I am new to NiFi. any advise can be helpful. > PS: I feel forcing Interfaces for Controller Services is unnecessary as in > many cases Controller Services are only used by a set of Processors and > developers usually bundle them together. > -- This message was sent by Atlassian JIRA (v6.3.4#6332)