Lehel44 commented on code in PR #6034:
URL: https://github.com/apache/nifi/pull/6034#discussion_r879888505
##########
nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/main/java/org/apache/nifi/snmp/processors/ListenTrapSNMP.java:
##########
@@ -65,14 +74,32 @@ public class ListenTrapSNMP extends
AbstractSessionFactoryProcessor {
.addValidator(StandardValidators.PORT_VALIDATOR)
.build();
- public static final PropertyDescriptor SNMP_USM_USERS_FILE_PATH = new
PropertyDescriptor.Builder()
+ public static final PropertyDescriptor SNMP_USM_USERS_JSON_FILE = new
PropertyDescriptor.Builder()
.name("snmp-usm-users-file-path")
- .displayName("SNMP Users File Path")
+ .displayName("SNMP Users JSON File")
.description("The path of the json file containing the user
credentials for SNMPv3. Check Usage for more details.")
- .required(true)
- .defaultValue("")
+ .required(false)
Review Comment:
I will refactor this part as you suggested creating a new property which
determines how we provide the USM data instead of displaying three properties
at once. And I'll do a compatibilty check in the end. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
