markobean commented on PR #6061: URL: https://github.com/apache/nifi/pull/6061#issuecomment-1138594164
> > @exceptionfactory The PR indicates you still have on outstanding requested change. The referenced comments discusses both `IllegalArgumentException` and overriding the `put()` method for a custom Properties class that will handles the duplicates like we want. I have addressed the latter. > > Are you still anticipating a change to the exception? The exception will in fact prevent NiFi from starting, but that is as intended. The discussion with @markap14 describes the rationale in more detail. > > Thanks for making the updates @markobean, the requested change status remains as I have not yet had chance to review the updates. I will take a closer look soon, but the recent changes look good from a cursory review. Roger that. I just wanted to be sure I knew who's court the ball was in -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
