[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1330: MINIFICPP-1832 Integrate first batch of clang-tidy checks in CI

Wed, 01 Jun 2022 03:25:42 -0700 


fgerlits commented on code in PR #1330:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1330#discussion_r886623725


##########
libminifi/src/FlowControlProtocol.cpp:
##########
@@ -280,11 +280,11 @@ int FlowControlProtocol::sendReportReq() {
   data = this->encode(data, hdr.msgType);
   data = this->encode(data, hdr.seqNumber);
   data = this->encode(data, hdr.status);
-  data = this->encode(data, hdr.payloadLen);
+  this->encode(data, hdr.payloadLen);

Review Comment:
   I think this should not have been changed: now `FLOW_YML_NAME` starts 
writing the buffer at the same point as where `hdr.payloadLen` started, 
overwriting it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to